diff options
| author | athenian200 <athenian200@outlook.com> | 2019-12-23 09:09:57 -0600 |
|---|---|---|
| committer | athenian200 <athenian200@outlook.com> | 2019-12-23 09:27:09 -0600 |
| commit | 735418fa363d2556d0ce40f0b4e67ff2bfc78b59 (patch) | |
| tree | 6a3e7b77783e9c8d7e0f8d18e791f6cdfdbb4e15 /dom/webidl | |
| parent | 84f4806b4656253faefd534cb59da27241608752 (diff) | |
| download | uxp-735418fa363d2556d0ce40f0b4e67ff2bfc78b59.tar.gz | |
Issue #1332 - Backport promise-based media playback
https://bugzilla.mozilla.org/show_bug.cgi?id=1244768
I happened to find an older version of the promise-based media playback patch in Bugzilla, the one that was originally submitted for review. It had the DocShell changes I already knew how to deal with, and had fewer of the audio wrapper and nsISupports changes that were confusing me in the later patch. I was able to do a better job getting this back into a UXP-appropriate configuration than I could have with the final version.
I'm honestly still a little unsure about some of the minor refactoring done in the patch itself, insisting on already_AddRefed promises and such, but I don't really know how to avoid those completely. Still, I think it's better than it was.
Diffstat (limited to 'dom/webidl')
| -rw-r--r-- | dom/webidl/HTMLMediaElement.webidl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/dom/webidl/HTMLMediaElement.webidl b/dom/webidl/HTMLMediaElement.webidl index 313686dacb..be79d8679c 100644 --- a/dom/webidl/HTMLMediaElement.webidl +++ b/dom/webidl/HTMLMediaElement.webidl @@ -68,7 +68,7 @@ interface HTMLMediaElement : HTMLElement { [SetterThrows] attribute boolean loop; [Throws] - void play(); + Promise<void> play(); [Throws] void pause(); |