diff options
| author | Matt A. Tobin <email@mattatobin.com> | 2019-11-10 19:11:03 -0500 |
|---|---|---|
| committer | Matt A. Tobin <email@mattatobin.com> | 2019-11-10 19:11:03 -0500 |
| commit | 201683afe4596ae32f7b1ea12dfca52995d59f9d (patch) | |
| tree | 8632173f59a85d1c3bf679653de7957a59c96eae /db/mork/src/morkNode.h | |
| parent | 4db1ae892bad565e8e59ec6034b4c98946077248 (diff) | |
| download | uxp-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.gz | |
Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors
* Part 1: make conversion CTORs explicit.
Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors.
* Part 2: fix a couple of double-mRefCnt declaration errors.
* Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16().
Tag #1273
Diffstat (limited to 'db/mork/src/morkNode.h')
| -rw-r--r-- | db/mork/src/morkNode.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/db/mork/src/morkNode.h b/db/mork/src/morkNode.h index 0bed96fd2b..02dbbb2295 100644 --- a/db/mork/src/morkNode.h +++ b/db/mork/src/morkNode.h @@ -56,7 +56,7 @@ public: mork_usage mUsage_Code; // kHeap, kStack, kMember, or kGhost public: - morkUsage(mork_usage inCode); + explicit morkUsage(mork_usage inCode); morkUsage(); // does nothing except maybe call EnsureReadyStaticUsage() void InitUsage( mork_usage inCode) @@ -163,7 +163,7 @@ public: // morkNode memory management operators protected: // construction without an anv needed for first env constructed: morkNode(const morkUsage& inUsage, nsIMdbHeap* ioHeap); - morkNode(mork_usage inCode); // usage == inCode, heap == nil + explicit morkNode(mork_usage inCode); // usage == inCode, heap == nil // { ===== begin basic node interface ===== public: // morkNode virtual methods |