summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMoonchild <moonchild@palemoon.org>2021-11-04 20:30:30 +0000
committerMoonchild <moonchild@palemoon.org>2021-11-04 20:30:30 +0000
commitec4a36a52902c30520921a47c0bea5e2a6b17c36 (patch)
tree7bdc0cb870467a54315cd500d3a272043fe1317d
parent5e653b9cb0a13587caa7015fc3717e4302385ea0 (diff)
downloadbasilisk-ec4a36a52902c30520921a47c0bea5e2a6b17c36.tar.gz
Prevent form popups from crossing the "line of death".
Without this, doorhangers could potentially be spoofed to overlap legitimate permission popups like geolocation or plugin permissions. Another reason doorhangers are evil!
-rw-r--r--basilisk/modules/FormValidationHandler.jsm2
1 files changed, 1 insertions, 1 deletions
diff --git a/basilisk/modules/FormValidationHandler.jsm b/basilisk/modules/FormValidationHandler.jsm
index e7e7b14..b88c282 100644
--- a/basilisk/modules/FormValidationHandler.jsm
+++ b/basilisk/modules/FormValidationHandler.jsm
@@ -124,7 +124,7 @@ var FormValidationHandler =
let tabBrowser = aWindow.gBrowser;
this._anchor = tabBrowser.popupAnchor;
this._anchor.left = aPanelData.contentRect.left;
- this._anchor.top = aPanelData.contentRect.top;
+ this._anchor.top = Math.max(0, aPanelData.contentRect.top);
this._anchor.width = aPanelData.contentRect.width;
this._anchor.height = aPanelData.contentRect.height;
this._anchor.hidden = false;