From 775b1b825fcf80bc02d5be09d7169770f5d9b32c Mon Sep 17 00:00:00 2001 From: janekptacijarabaci Date: Sat, 28 Apr 2018 12:27:35 +0200 Subject: [DevTools] Storage - style clean up - a check of the variable to see if it exists Issue #102 --- devtools/client/storage/ui.js | 41 +++++++++++++++++++++++------------------ 1 file changed, 23 insertions(+), 18 deletions(-) (limited to 'devtools') diff --git a/devtools/client/storage/ui.js b/devtools/client/storage/ui.js index 7745c8da96..47f6e7074a 100644 --- a/devtools/client/storage/ui.js +++ b/devtools/client/storage/ui.js @@ -482,24 +482,27 @@ StorageUI.prototype = { * @param {object} See onUpdate docs */ handleChangedItems: function (changed) { - if (this.tree.selectedItem) { - let [type, host, db, objectStore] = this.tree.selectedItem; - if (!changed[type] || !changed[type][host] || - changed[type][host].length == 0) { - return; - } - try { - let toUpdate = []; - for (let name of changed[type][host]) { - let names = JSON.parse(name); - if (names[0] == db && names[1] == objectStore && names[2]) { - toUpdate.push(name); - } + let selectedItem = this.tree.selectedItem; + if (!selectedItem) { + return; + } + + let [type, host, db, objectStore] = selectedItem; + if (!changed[type] || !changed[type][host] || + changed[type][host].length == 0) { + return; + } + try { + let toUpdate = []; + for (let name of changed[type][host]) { + let names = JSON.parse(name); + if (names[0] == db && names[1] == objectStore && names[2]) { + toUpdate.push(name); } - this.fetchStorageObjects(type, host, toUpdate, REASON.UPDATE); - } catch (ex) { - this.fetchStorageObjects(type, host, changed[type][host], REASON.UPDATE); } + this.fetchStorageObjects(type, host, toUpdate, REASON.UPDATE); + } catch (ex) { + this.fetchStorageObjects(type, host, changed[type][host], REASON.UPDATE); } }, @@ -830,6 +833,7 @@ StorageUI.prototype = { if (!item) { return; } + this.table.clear(); this.hideSidebar(); this.searchBox.value = ""; @@ -1136,11 +1140,12 @@ StorageUI.prototype = { * Handles adding an item from the storage */ onAddItem: function () { - if (!this.tree.selectedItem) { + let selectedItem = this.tree.selectedItem; + if (!selectedItem) { return; } let front = this.getCurrentFront(); - let [, host] = this.tree.selectedItem; + let [, host] = selectedItem; // Prepare to scroll into view. this.table.scrollIntoViewOnUpdate = true; -- cgit v1.2.3 From 8f65db7541d1a34b5696d888431d9b5189f4fe65 Mon Sep 17 00:00:00 2001 From: janekptacijarabaci Date: Sat, 28 Apr 2018 12:53:10 +0200 Subject: [DevTools] Storage - style clean up - a check of the variable to see if it exists (an empty line) Issue #102 --- devtools/client/storage/ui.js | 1 + 1 file changed, 1 insertion(+) (limited to 'devtools') diff --git a/devtools/client/storage/ui.js b/devtools/client/storage/ui.js index 47f6e7074a..5bd29d297b 100644 --- a/devtools/client/storage/ui.js +++ b/devtools/client/storage/ui.js @@ -1144,6 +1144,7 @@ StorageUI.prototype = { if (!selectedItem) { return; } + let front = this.getCurrentFront(); let [, host] = selectedItem; -- cgit v1.2.3