diff options
| author | trav90 <travawine@protonmail.ch> | 2018-04-07 12:24:30 -0500 |
|---|---|---|
| committer | trav90 <travawine@protonmail.ch> | 2018-04-07 13:11:38 -0500 |
| commit | bbd4001cb261cc54e2adf804ea7cbeb09078d7d9 (patch) | |
| tree | 581523beea01c0b144051caebb6cb8a95539717a /js/src/jsfriendapi.h | |
| parent | d960419686462067cb5745dcd1ad264abe0b1485 (diff) | |
| download | uxp-bbd4001cb261cc54e2adf804ea7cbeb09078d7d9.tar.gz | |
Fix Value::isGCThing footgun, stop returning true for NullValue
Diffstat (limited to 'js/src/jsfriendapi.h')
| -rw-r--r-- | js/src/jsfriendapi.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/js/src/jsfriendapi.h b/js/src/jsfriendapi.h index b1c7cb0dcb..7220855491 100644 --- a/js/src/jsfriendapi.h +++ b/js/src/jsfriendapi.h @@ -761,7 +761,7 @@ SetReservedSlot(JSObject* obj, size_t slot, const JS::Value& value) { MOZ_ASSERT(slot < JSCLASS_RESERVED_SLOTS(GetObjectClass(obj))); shadow::Object* sobj = reinterpret_cast<shadow::Object*>(obj); - if (sobj->slotRef(slot).isMarkable() || value.isMarkable()) + if (sobj->slotRef(slot).isGCThing() || value.isGCThing()) SetReservedOrProxyPrivateSlotWithBarrier(obj, slot, value); else sobj->slotRef(slot) = value; |