diff options
| author | FranklinDM <mrmineshafter17@gmail.com> | 2022-04-18 02:52:07 +0800 |
|---|---|---|
| committer | FranklinDM <mrmineshafter17@gmail.com> | 2022-04-18 23:44:27 +0800 |
| commit | 3a565183f0e846cfe29594a2ca096d6272d52b3f (patch) | |
| tree | 6ef5da06e6e6afbaac717a18709fad41354ff81e | |
| parent | 145947d86b7d8072b4b12a955e642e21873dd212 (diff) | |
| download | uxp-3a565183f0e846cfe29594a2ca096d6272d52b3f.tar.gz | |
Issue #738 - Follow-up: Remove explicit session cache cleanup routine from ShutdownNSS
This is no longer needed because the call to SSL_ConfigServerSessionIDCache on startup was already removed (see 1425f020c47b3cbe134f71717299714aead28502), meaning LocksInitializedEarly does not become true and only causes an assertion on debug builds.
On the other hand, SSL_ClearSessionCache is already called on XPCOM shutdown and calling it again here is redundant.
Additional context: https://bugzilla.mozilla.org/show_bug.cgi?id=1485087#c5
Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1485087
| -rw-r--r-- | security/manager/ssl/nsNSSComponent.cpp | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/security/manager/ssl/nsNSSComponent.cpp b/security/manager/ssl/nsNSSComponent.cpp index 7880959c9f..82defa2e83 100644 --- a/security/manager/ssl/nsNSSComponent.cpp +++ b/security/manager/ssl/nsNSSComponent.cpp @@ -1948,10 +1948,6 @@ nsNSSComponent::ShutdownNSS() #ifndef MOZ_NO_SMART_CARDS ShutdownSmartCardThreads(); #endif - SSL_ClearSessionCache(); - // TLSServerSocket may be run with the session cache enabled. This ensures - // those resources are cleaned up. - Unused << SSL_ShutdownServerSessionIDCache(); MOZ_LOG(gPIPNSSLog, LogLevel::Debug, ("evaporating psm resources")); if (NS_FAILED(nsNSSShutDownList::evaporateAllNSSResources())) { |